Skip to content

Revisiting nullable annotations on caching#66215

Merged
eerhardt merged 2 commits into
dotnet:mainfrom
maryamariyan:nullable-caching
Mar 7, 2022
Merged

Revisiting nullable annotations on caching#66215
eerhardt merged 2 commits into
dotnet:mainfrom
maryamariyan:nullable-caching

Conversation

@maryamariyan

@maryamariyan maryamariyan commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

This PR fixes some mismatches between nullability of the arguments between ref and src

@ghost

ghost commented Mar 4, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Mar 4, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-caching
See info in area-owners.md if you want to be subscribed.

Issue Details

Using GenerateReferenceAssemblySource target on caching libraries I noticed a mismatch between nullability of the arguments between ref and src for Microsoft.Extensions.Caching.Abstraction for CacheExtensions.GetOrCreateAsync and for PostEvictionDelegate.

@eerhardt @maxkoshevoi could you please review?

Author: maryamariyan
Assignees: maryamariyan
Labels:

new-api-needs-documentation, area-Extensions-Caching

Milestone: -

@maryamariyan

Copy link
Copy Markdown
Contributor Author

Updated this PR, some of the changes were already addressed in #65804

@tarekgh

tarekgh commented Mar 4, 2022

Copy link
Copy Markdown
Member

@maryamariyan I am seeing this PR changes almost no-op. am I missing anything here?

@maryamariyan

Copy link
Copy Markdown
Contributor Author

PR is ready for review.

@tarekgh aside from changes requested by @eerhardt in #65775 I am also fixing the placement of Clear in caching ref file, as dictated via GenerateReferenceAssemblySource target.

@eerhardt eerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@maxkoshevoi maxkoshevoi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eerhardt eerhardt merged commit 440dfe4 into dotnet:main Mar 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants