Skip to content

Fix cross-arch build compilation error about missing O_RDONLY#66094

Merged
stephentoub merged 1 commit into
dotnet:mainfrom
stephentoub:fixcrossbuild
Mar 2, 2022
Merged

Fix cross-arch build compilation error about missing O_RDONLY#66094
stephentoub merged 1 commit into
dotnet:mainfrom
stephentoub:fixcrossbuild

Conversation

@stephentoub

@stephentoub stephentoub commented Mar 2, 2022

Copy link
Copy Markdown
Member

I hit an error with the latest Visual Studio preview build.
cc: @janvorli

@ghost ghost assigned stephentoub Mar 2, 2022
@ghost ghost added the area-Infrastructure-coreclr Only use for closed issues label Mar 2, 2022
@ghost

ghost commented Mar 2, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

cc: @janvorli

Author: stephentoub
Assignees: stephentoub
Labels:

area-Infrastructure-coreclr

Milestone: -

@adamsitnik adamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that it solves the problem:

image

@hoyosjs

hoyosjs commented Mar 2, 2022

Copy link
Copy Markdown
Member

Odd one hit, looks like #65914

Assert failure(PID 566 [0x00000236], Thread: 590 [0x024e]): waitResult == WAIT_TIMEOUT
    File: /__w/1/s/src/coreclr/vm/tieredcompilation.cpp Line: 507
    Image: /root/helix/work/correlation/dotnet

For the reflection issue created #66100 as it's hitting several builds.

@janvorli janvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@stephentoub stephentoub merged commit d543bc4 into dotnet:main Mar 2, 2022
@stephentoub stephentoub deleted the fixcrossbuild branch March 2, 2022 21:29
@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclr Only use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants