Skip to content

Annotate System.IO.FileSystem for nullable #590

Merged
buyaa-n merged 8 commits into
dotnet:masterfrom
buyaa-n:io_filesystem
Dec 11, 2019
Merged

Annotate System.IO.FileSystem for nullable #590
buyaa-n merged 8 commits into
dotnet:masterfrom
buyaa-n:io_filesystem

Conversation

@buyaa-n

@buyaa-n buyaa-n commented Dec 5, 2019

Copy link
Copy Markdown
Contributor

Reopening #531 as that PR was created from master branch
CC @stephentoub @safern

@buyaa-n buyaa-n requested review from safern and stephentoub December 5, 2019 21:30
@buyaa-n buyaa-n mentioned this pull request Dec 5, 2019
Closed
buyaa-n
buyaa-n commented Dec 6, 2019
View reviewed changes
Comment thread src/libraries/System.IO.FileSystem/src/System/IO/Directory.cs Outdated
stephentoub
stephentoub reviewed Dec 10, 2019
View reviewed changes
Comment thread src/libraries/System.IO.FileSystem/src/System/IO/Iterator.cs Outdated
@buyaa-n

buyaa-n commented Dec 11, 2019

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries

@azure-pipelines

azure-pipelines Bot commented Dec 11, 2019

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@buyaa-n

buyaa-n commented Dec 11, 2019

Copy link
Copy Markdown
Contributor Author

/azp run runtime

@azure-pipelines

azure-pipelines Bot commented Dec 11, 2019

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@buyaa-n

buyaa-n commented Dec 11, 2019

Copy link
Copy Markdown
Contributor Author

Seems runtime builds are not working properly and not related to the PR. As libraries build passed gonna merge

@buyaa-n buyaa-n merged commit 96d9a47 into dotnet:master Dec 11, 2019
@buyaa-n buyaa-n deleted the io_filesystem branch February 13, 2020 01:33
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
MichalStrehovsky pushed a commit to MichalStrehovsky/runtime that referenced this pull request Mar 25, 2021
@jkotas
Add check for .NET 5 SDK, update NativeLibrary sample instructions (d…
0a644c7 
…otnet#601)

Fixes dotnet#590
Fixes dotnet#589
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes
@safern safern safern approved these changes
@carlossanlop carlossanlop Awaiting requested review from carlossanlop
@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne

Assignees

No one assigned

Labels

area-System.IO

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@buyaa-n @stephentoub @safern @Dotnet-GitSync-Bot