Fix rva ordering take2#55861
Closed
davidwrighton wants to merge 5 commits into
Closed
Conversation
… in a composite image (dotnet#55301)" (dotnet#55713)" This reverts commit 87fcf6e.
…ed to the final binary
ghost
added
the
- This doesn't actually work, as the test needs to be compiled as architecture specific, without ILOnly enabled which our current build pipeline cannot do. - Also, then crossgen2 will identify the binaries as C++/CLI and refuse to compile them.
Member
Author
|
This only effects C++/CLI scenarios are already unsupported by crossgen2 in .NET 6, so I'm closing this PR for now. I'll update it with a change that fixes the issue, but at this time, I do not think it is worth the risk/cost of fixing the bug in .NET 6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes composite mode compilation of src/tests/Directed/rvastatics/RVAOrderingTest.ilproj
Earlier fix was reverted as it broke composite construction of CoreLib, this fix should be more correct.