[mono][aot] Fix --full-aot-interp support on amd64.#52861
Merged
Conversation
vargaz
requested review from
CoffeeFlux,
SamMonoRT,
imhameed and
lambdageek
as code owners
ghost
added
the
lambdageek
reviewed
May 17, 2021
We need to generate more trampolines since a lot of runtime code generates trampolines even in --full-aot-interp mode. Fixes dotnet#52848.
lambdageek
reviewed
May 17, 2021
lambdageek
approved these changes
May 17, 2021
lambdageek
left a comment
lambdageek
left a comment
Member
There was a problem hiding this comment.
LGTM, @BrzVlad could you take a look, too.
BrzVlad
approved these changes
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to generate more trampolines since a lot of runtime code generates
trampolines even in --full-aot-interp mode.
Fixes #52848.