Address remaining warnings from DataContractSerialization#51200

Merged

10 commits merged into

dotnet:mainfrom

joperezr:SPDCS2

Apr 19, 2021

joperezr commented Apr 13, 2021

Member

Contributes to #45623

This Resolves the remaining warnings on System.Private.DataContractSerialization.

cc: @eerhardt @vitek-karas


          Address remaining warnings from DataContractSerialization

dee65c7

joperezr added area-Serialization linkable-framework labels

joperezr requested a review from eerhardt

April 13, 2021 22:06

ghost commented Apr 13, 2021 •

edited by joperezr

Loading

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @tannergooding, @sbomer
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #45623

This Resolves the remaining warnings on System.Private.DataContractSerialization.

cc: @eerhardt @vitek-karas

Author:	joperezr
Assignees:	-
Labels:	`area-Serialization`, `linkable-framework`
Milestone:	-

In reply to: 819084419

ghost added the new-api-needs-documentation label

ghost commented Apr 13, 2021 •

edited by joperezr

Loading

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

In reply to: 819084428

joperezr requested a review from mconnew

April 13, 2021 22:07

joperezr commented Apr 13, 2021 •

edited

Loading

Member Author

In reply to: 819084588

eerhardt reviewed

View reviewed changes

...stem.Private.DataContractSerialization/src/System/Runtime/Serialization/ClassDataContract.cs Outdated


          Refactor MemberTypes declaration

74a721a

eerhardt reviewed

View reviewed changes

...Private.DataContractSerialization/src/System/Runtime/Serialization/CollectionDataContract.cs Outdated


          Remove Unused UnconditionalSuppressMessages

1cfd78f

eerhardt reviewed

View reviewed changes

...Private.DataContractSerialization/src/System/Runtime/Serialization/CollectionDataContract.cs Outdated

eerhardt reviewed

View reviewed changes

...Private.DataContractSerialization/src/System/Runtime/Serialization/CollectionDataContract.cs Outdated

eerhardt reviewed

View reviewed changes

...Private.DataContractSerialization/src/System/Runtime/Serialization/CollectionDataContract.cs Outdated

eerhardt reviewed

View reviewed changes

...ries/System.Private.DataContractSerialization/src/System/Runtime/Serialization/DataMember.cs Outdated

eerhardt reviewed

View reviewed changes

....Private.DataContractSerialization/src/System/Runtime/Serialization/PrimitiveDataContract.cs Outdated

eerhardt reviewed

View reviewed changes

...vate.DataContractSerialization/src/System/Runtime/Serialization/XmlFormatGeneratorStatics.cs Outdated

eerhardt reviewed

View reviewed changes

...ivate.DataContractSerialization/src/System/Runtime/Serialization/XmlFormatReaderGenerator.cs Outdated

vitek-karas reviewed

View reviewed changes

...System.Private.DataContractSerialization/src/System/Runtime/Serialization/AccessorBuilder.cs Outdated

vitek-karas reviewed

View reviewed changes

...System.Private.DataContractSerialization/src/System/Runtime/Serialization/AccessorBuilder.cs Outdated

vitek-karas reviewed

View reviewed changes

...System.Private.DataContractSerialization/src/System/Runtime/Serialization/AccessorBuilder.cs Outdated

joperezr added 4 commits

April 15, 2021 10:56


          Addressing some PR Feedback

dadc858


          Suppress MakeGenericMethod calls in AccessorBuilder

c3446d0


          Suppressing error in NullPrimitiveDataContract constructor


          Suppress other MakeGenericMethod linker warnings

64d7a44

eerhardt approved these changes

View reviewed changes

eerhardt left a comment

Member

Looks good. Just some minor-ish comments.

...ystem.Private.DataContractSerialization/src/System/Runtime/Serialization/ReflectionReader.cs Outdated

...System.Private.DataContractSerialization/src/System/Runtime/Serialization/AccessorBuilder.cs Outdated

...System.Private.DataContractSerialization/src/System/Runtime/Serialization/AccessorBuilder.cs Outdated

...Private.DataContractSerialization/src/System/Runtime/Serialization/CollectionDataContract.cs Outdated

mconnew reviewed

View reviewed changes

...ataContractSerialization/src/System/Runtime/Serialization/Json/DataContractJsonSerializer.cs Outdated


          Address remaining feedback and move trimmer string to DataContract

0a7ed79

mconnew reviewed

View reviewed changes

....Private.DataContractSerialization/src/System/Runtime/Serialization/PrimitiveDataContract.cs Outdated

mconnew reviewed

View reviewed changes

....Private.DataContractSerialization/src/System/Runtime/Serialization/PrimitiveDataContract.cs Outdated

mconnew reviewed

View reviewed changes

...em.Private.DataContractSerialization/src/System/Runtime/Serialization/XmlObjectSerializer.cs

                   public abstract class XmlObjectSerializer
                   {
+                      [RequiresUnreferencedCode(DataContractJsonSerializer.SerializerTrimmerWarning)]
                       public abstract void WriteStartObject(XmlDictionaryWriter writer, object? graph);

mconnew Apr 16, 2021

Member

This isn't necessarily true. This class is public abstract and may not require unreferenced code. WCF carries an implementation of this abstract type and customers might in their own code too. The WCF implementation does delegate work to XmlSerializer (which doesn't implement this abstract class) and doesn't reference anything from DCS or DCJS.

eerhardt Apr 16, 2021

Member

The way the API is shaped - object? graph - doesn't lead to being trim compatible. The trimmer has no way of knowing statically which Types are being passed into WriteStartObject. Therefore, it doesn't know what members on what Types should be preserved.

Even if you looked at the type of variables:

Customer c = GetSomeCustomer();
serializer.WriteStartObject(writer, c);

You don't know statically if c is concretely a Customer or a type derived from Customer.

mconnew commented Apr 16, 2021

Member

@StephenMolloy as he owns DCS and DCJS


          Addressing some nits

1c1ee28

mconnew reviewed

View reviewed changes

...System.Private.DataContractSerialization/src/System/Runtime/Serialization/AccessorBuilder.cs

mconnew reviewed

View reviewed changes

...stem.Private.DataContractSerialization/src/System/Runtime/Serialization/ClassDataContract.cs

joperezr added the auto-merge label

ghost commented Apr 19, 2021

Hello @joperezr!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

mconnew approved these changes

View reviewed changes


          Fix typo and remove unnecesary usings

dc09fcf

joperezr force-pushed the SPDCS2 branch from a780e02 to dc09fcf Compare

April 19, 2021 20:14

ghost merged commit 989ba28 into dotnet:main

runfoapp Bot mentioned this pull request

Intermittent failure to restore IBC optimization data #51585

Closed

eerhardt mentioned this pull request

DataContractSerialization is not linker friendly #36154

Closed

ghost locked as resolved and limited conversation to collaborators

karelz added this to the 6.0.0 milestone

joperezr deleted the SPDCS2 branch

August 11, 2021 21:00

This pull request was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Serialization linkable-framework new-api-needs-documentation