Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,9 @@ private static void PollForValues()
// We cache these outside of the scope of s_counterGroupLock because
// calling into the callbacks can cause a re-entrancy into CounterGroup.Enable()
// and result in a deadlock. (See https://github.com/dotnet/runtime/issues/40190 for details)
List<Action> onTimers = new List<Action>();
var onTimers = new List<CounterGroup>();
while (true)
{
onTimers.Clear();
int sleepDurationInMilliseconds = int.MaxValue;
lock (s_counterGroupLock)
{
Expand All @@ -284,18 +283,19 @@ private static void PollForValues()
DateTime now = DateTime.UtcNow;
if (counterGroup._nextPollingTimeStamp < now + new TimeSpan(0, 0, 0, 0, 1))
{
onTimers.Add(() => counterGroup.OnTimer());
onTimers.Add(counterGroup);
}

int millisecondsTillNextPoll = (int)((counterGroup._nextPollingTimeStamp - now).TotalMilliseconds);
millisecondsTillNextPoll = Math.Max(1, millisecondsTillNextPoll);
sleepDurationInMilliseconds = Math.Min(sleepDurationInMilliseconds, millisecondsTillNextPoll);
}
}
foreach (Action onTimer in onTimers)
foreach (CounterGroup onTimer in onTimers)
{
onTimer.Invoke();
onTimer.OnTimer();
}
onTimers.Clear();
if (sleepDurationInMilliseconds == int.MaxValue)
{
sleepDurationInMilliseconds = -1; // WaitOne uses -1 to mean infinite
Expand Down