Skip to content

Add 3.1 to package index / validation#49792

Merged
ericstj merged 2 commits into
dotnet:mainfrom
ericstj:3.1inboxUpdate
Mar 18, 2021
Merged

Add 3.1 to package index / validation#49792
ericstj merged 2 commits into
dotnet:mainfrom
ericstj:3.1inboxUpdate

Conversation

@ericstj

@ericstj ericstj commented Mar 18, 2021

Copy link
Copy Markdown
Member

Replaces #49781

@ghost

ghost commented Mar 18, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Replaces #49781

Author: ericstj
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@GrabYourPitchforks

Copy link
Copy Markdown
Member

I am totally underqualified to review this PR. :)

But out of curiosity, I wonder if it would make sense to start performing cleanup of this as RIDs drop off. For instance, netcoreapp2.0 and netcoreapp3.0 are out of support, netcoreapp2.1 will be out of support by the time this wave ships, and so on. It doesn't affect this PR in any way, but it makes me wonder if we should do a grand pass of this and all of our ref\*.csproj and src\*.csproj files.

@ViktorHofer

Copy link
Copy Markdown
Member

It doesn't affect this PR in any way, but it makes me wonder if we should do a grand pass of this and all of our ref*.csproj and src*.csproj files.

After removing harvested assets, this would be the next iteration of trimming out package assets that aren't applicable to modern workloads anymore.

@GrabYourPitchforks

Copy link
Copy Markdown
Member

I kicked the staging step again, but CI looked green otherwise.

@ericstj

ericstj commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

But out of curiosity, I wonder if it would make sense to start performing cleanup

This whole validation process should be wholesale replaced with the shipping functionality that @safern and @anpik are working on. PackageIndex, SupportedFramework, etc will go away 🤞

@GrabYourPitchforks

Copy link
Copy Markdown
Member

@ericstj @safern Is there any other signoff or validation we're waiting for?

@ericstj

ericstj commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

Nope, this looks good.

@ericstj ericstj merged commit f58730b into dotnet:main Mar 18, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants