Support loading ICU data from managed Interop#49406
Conversation
In iOS we support loading a custom dat file when working with ICU. The way this worked originally was the mono runtime exported a function that native code would call into (similar to wasm). After thinking about it a bit, it makes more sense to load this the same way we do on desktop, but with the ability to provide the path to an ICU dat file via an AppContext key `ICU_DAT_FILE_PATH`. This can be provided before Xamarin iOS calls `monovm_initialize` and they won't have to worry about calling some special function.
ghost
added
the
|
Tagging subscribers to this area: @tarekgh, @safern Issue DetailsIn iOS we support loading a custom dat file when working with ICU. The way this worked originally was the mono runtime exported a function that native code would call into (similar to wasm). After thinking about it a bit, it makes more sense to load ICU the same way we do on desktop, but with the ability to provide the path to an ICU dat file via an AppContext key
|
steveisok
requested review from
akoeplinger,
lambdageek,
marek-safar and
safern
|
How we'll guarantee the loaded data file will be compatible with the loaded ICU code library? I am guessing we can run into some issues that will be hard to diagnose if the data is not compatible with the code library. |
For iOS, we'll control the version that we're using and the data file that comes with it. Beyond that, good question. |
steveisok
requested review from
CoffeeFlux,
SamMonoRT and
vargaz
as code owners
CoffeeFlux
left a comment
CoffeeFlux
left a comment
There was a problem hiding this comment.
Sorry for hitting you with a bunch of style nits again.
Otherwise looks fine to me, thanks!
|
|
||
| return load_icu_data (icu_data); | ||
| if (load_icu_data(icu_data) == 0) { | ||
| fprintf(stderr, "ICU BAD EXIT %d.", ret); |
There was a problem hiding this comment.
fprintf [](start = 8, length = 7)
should we do log_icu_error instead in all places writing to the stderr?
tarekgh
left a comment
tarekgh
left a comment
There was a problem hiding this comment.
Added some minor comments. LGTM otherwise.
| bundle, | ||
| #ifndef INVARIANT_GLOBALIZATION | ||
| icu_dat_path, | ||
| icu_dat_path |
There was a problem hiding this comment.
nit: trailing commas are not an error.
(and they play nicer with git history when someone adds the next array entry)
|
Mono windows test failures are unrelated #49569 |
8 participants
In iOS we support loading a custom dat file when working with ICU. The way this worked originally was the mono runtime exported a function that native code would call into (similar to wasm). After thinking about it a bit, it makes more sense to load ICU the same way we do on desktop, but with the ability to provide the path to an ICU dat file via an AppContext key
ICU_DAT_FILE_PATH. The key can be provided before Xamarin iOS callsmonovm_initializeand they won't have to worry about calling some special function.