Fix HttpClientHandler_ServerCertificates_Test#49130
Merged
Merged
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #49028, which is a regression caused by an overlook in #48817.
|
Contributor
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ManickaP
approved these changes
Mar 4, 2021
ManickaP
left a comment
ManickaP
left a comment
Member
There was a problem hiding this comment.
LGTM if the test will eventually pass, thanks.
stephentoub
approved these changes
Mar 4, 2021
Contributor
Author
|
The only Http test failure is #44352, which is unrelated. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49028, which is a regression caused by an overlook in #48817.
HttpClientHandler_ServerCertificates_Testshould also have a custom overload forCreateHttpClient()not onlyCreateHttpClientHandler(), otherwiseServerCertificateCustomValidationCallbackwon't be configured correctly in member test cases usingCreateHttpClient().