Skip to content

In conservative mode RedirectedThreadFrame should report registers to GC. #48923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5 commits merged into from
Mar 2, 2021
Merged

In conservative mode RedirectedThreadFrame should report registers to GC. #48923

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ed0b28f
Report registers from RedirectedThreadFrame
VSadov Mar 1, 2021
8032b37
TEST ONLY: enable conservative by default.
VSadov Mar 1, 2021
54a663a
fixes for ARM
VSadov Mar 1, 2021
0a9489a
Ebp can also contain roots.
VSadov Mar 1, 2021
c87a3b8
undoing test-only config changes
VSadov Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/coreclr/vm/frames.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,36 @@ class RedirectedThreadFrame : public ResumableFrame
virtual void ExceptionUnwind();
#endif

virtual void GcScanRoots(promote_func* fn, ScanContext* sc)
{
WRAPPER_NO_CONTRACT;
#if defined(FEATURE_CONSERVATIVE_GC) && !defined(DACCESS_COMPILE)
if (sc->promotion && g_pConfig->GetGCConservative())
{

#ifdef TARGET_AMD64
Object** firstIntReg = (Object**)&this->GetContext()->Rax;
Object** lastIntReg = (Object**)&this->GetContext()->R15;
#elif defined(TARGET_X86)
Object** firstIntReg = (Object**)&this->GetContext()->Edi;
Object** lastIntReg = (Object**)&this->GetContext()->Ebp;
#elif defined(TARGET_ARM)
Object** firstIntReg = (Object**)&this->GetContext()->R0;
Object** lastIntReg = (Object**)&this->GetContext()->R12;
#elif defined(TARGET_ARM64)
Object** firstIntReg = (Object**)&this->GetContext()->X0;
Object** lastIntReg = (Object**)&this->GetContext()->X28;
#else
_ASSERTE(!"nyi for platform");
#endif
for (Object** ppObj = firstIntReg; ppObj <= lastIntReg; ppObj++)
{
fn(ppObj, sc, GC_CALL_INTERIOR | GC_CALL_PINNED);
}
}
#endif
}

// Keep as last entry in class
DEFINE_VTABLE_GETTER_AND_CTOR_AND_DTOR(RedirectedThreadFrame)
};
Expand Down