Avoid race conditions when building linker tests#48028
Avoid race conditions when building linker tests#48028ViktorHofer merged 3 commits intodotnet:masterfrom
Conversation
|
Tagging subscribers to this area: @safern, @ViktorHofer Issue DetailsFixes #40398 Changes:
Filed #48027 to fix an unnecessary excessive amount of NuGet invocation.
|
|
@ViktorHofer are we waiting for the linker version PR to get merged on Arcade first in order to merge this? If this is not currently blocked, it would be good to get it in since I'm currently working on adding a browser-wasm leg for the trimming tests, and it will be much easier to do it once we publish the test apps in-proc in order to be able to import all of the current infra for building the wasm bundle. |
|
To make sure that the right linker is always used we require a newer SDK as ILLink imports were wrongly sequenced. That said, the right linker is currently used and I don't think we should block the PR on that. Just need an approval and then it's ready to be merged. |
eerhardt
left a comment
There was a problem hiding this comment.
This looks reasonable to me. Thanks for helping out here, @ViktorHofer!
|
The build hang for 2h during downloading CoreCLR artifacts. Pinged @MattGal about this offline. |
Fixes #40398
Depends on dotnet/arcade#6936
Changes:
Filed #48027 to fix an unnecessary excessive amount of NuGet invocation.