Skip to content

Avoid race conditions when building linker tests#48028

Merged
ViktorHofer merged 3 commits intodotnet:masterfrom
ViktorHofer:LinkerTestsCleanup
Feb 12, 2021
Merged

Avoid race conditions when building linker tests#48028
ViktorHofer merged 3 commits intodotnet:masterfrom
ViktorHofer:LinkerTestsCleanup

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Feb 9, 2021

Fixes #40398
Depends on dotnet/arcade#6936

Changes:

  • Use static graph restore for linker tests
  • Use in-proc MSBuild task to publish linker test projects
  • Enabled parallel building of linker tests
  • Code clean up...

Filed #48027 to fix an unnecessary excessive amount of NuGet invocation.

@ghost
Copy link

ghost commented Feb 9, 2021

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #40398

Changes:

  • Use static graph restore for linker tests
  • Use in-proc MSBuild task to publish linker test projects
  • Enabled parallel building of linker tests
  • Code clean up...

Filed #48027 to fix an unnecessary excessive amount of NuGet invocation.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

@joperezr
Copy link
Member

@ViktorHofer are we waiting for the linker version PR to get merged on Arcade first in order to merge this? If this is not currently blocked, it would be good to get it in since I'm currently working on adding a browser-wasm leg for the trimming tests, and it will be much easier to do it once we publish the test apps in-proc in order to be able to import all of the current infra for building the wasm bundle.

@ViktorHofer
Copy link
Member Author

To make sure that the right linker is always used we require a newer SDK as ILLink imports were wrongly sequenced. That said, the right linker is currently used and I don't think we should block the PR on that. Just need an approval and then it's ready to be merged.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Thanks for helping out here, @ViktorHofer!

@ViktorHofer
Copy link
Member Author

The build hang for 2h during downloading CoreCLR artifacts. Pinged @MattGal about this offline.

@ViktorHofer ViktorHofer merged commit edaa380 into dotnet:master Feb 12, 2021
@ViktorHofer ViktorHofer deleted the LinkerTestsCleanup branch February 12, 2021 19:16
@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trimming tests fail with race condition

5 participants