Skip to content

Add System.Linq Chunk extension method#47965

Merged
eiriktsarpalis merged 9 commits into
dotnet:masterfrom
inputfalken:linq-chunk-extension-method
Feb 10, 2021
Merged

Add System.Linq Chunk extension method#47965
eiriktsarpalis merged 9 commits into
dotnet:masterfrom
inputfalken:linq-chunk-extension-method

Conversation

@inputfalken

Copy link
Copy Markdown
Contributor

Fix #27449

Some things I would especially like feedback on is:

  • The implementation for IQueryable<T> and its unit tests.
  • How to properly test that the optimization from System\Linq\Chunk.SpeedOpt.cs is actually used.
  • If the documentation is in the correct place.

@ghost

ghost commented Feb 6, 2021

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Feb 6, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #27449

Some things I would especially like feedback on is:

  • The implementation for IQueryable<T> and its unit tests.
  • How to properly test that the optimization from System\Linq\Chunk.SpeedOpt.cs is actually used.
  • If the documentation is in the correct place.
Author: inputfalken
Assignees: -
Labels:

area-System.Linq, new-api-needs-documentation

Milestone: -

Comment thread src/libraries/System.Linq/src/System/Linq/Chunk.SpeedOpt.cs Outdated
Comment thread src/libraries/System.Linq/src/System/Linq/Chunk.cs Outdated
Comment thread src/libraries/System.Linq/src/System/Linq/Chunk.cs Outdated
Comment thread src/libraries/System.Linq/src/System/Linq/Chunk.SpeedOpt.cs Outdated
Comment thread src/libraries/System.Linq/src/System/Linq/Chunk.SpeedOpt.cs Outdated
Comment thread src/libraries/System.Linq/src/System/Linq/Chunk.SpeedOpt.cs Outdated
Comment thread src/libraries/System.Linq/src/System/Linq/Chunk.cs Outdated
Comment thread src/libraries/System.Linq/src/System/Linq/Chunk.cs Outdated
Comment thread src/libraries/System.Linq/src/System/Linq/Chunk.cs Outdated
Comment thread src/libraries/System.Linq.Queryable/ref/System.Linq.Queryable.cs Outdated
Comment thread src/libraries/System.Linq.Queryable/tests/ChunkTests.cs Outdated
Comment thread src/libraries/System.Linq/tests/ChunkTests.cs Outdated
Comment thread src/libraries/System.Linq/tests/ChunkTests.cs Outdated

@eiriktsarpalis eiriktsarpalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@eiriktsarpalis

Copy link
Copy Markdown
Member

Build failure

NETCORE_ENGINEERING_TELEMETRY=Build) Validation Failed: System.Drawing.Common is harvesting assets from package version 5.0.0 which is not the latest for that package release.

seems unrelated to the change, merging away.

@eiriktsarpalis eiriktsarpalis merged commit 515bfaf into dotnet:master Feb 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IEnumerable should have a extension for creating fixed size chunks

3 participants