Use C EventPipe implementation by default#47665
Merged
Merged
Conversation
added 2 commits
January 29, 2021 15:45
* adaptor and shim classes remain in case we ever add further targets for EventPipe
am11
reviewed
Jan 30, 2021
am11
reviewed
Jan 30, 2021
* rename standalone pal flag
davmason
approved these changes
Jan 30, 2021
noahfalk
approved these changes
Jan 31, 2021
sywhang
approved these changes
Jan 31, 2021
lateralusX
approved these changes
Feb 1, 2021
Member
|
@lateralusX @josalem Thank you for making this happen! |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adaptors and shims are left as is to accommodate any future runtime targets for the EventPipe library.
The C++ source files and headers were removed as part of this switch. It's a separate commit, so we could make it a separate PR if we feel the need to keep the files around.
closes #46079
I ran end-to-end tests with our diagnostic tools on my MacBook locally. Traces collected opened in PerfView fine.
dotnet-gcdumpwas able to report heap stats correctly.dotnet-dumpwas able to generate usable memory dumps.CC @dotnet/dotnet-diag @tommcdon @sywhang @noahfalk @lateralusX