Skip to content

Respect offset in Socket.ReceiveMessageFrom(saea) on Windows#47642

Merged
antonfirsov merged 7 commits into
dotnet:masterfrom
antonfirsov:sockets/ReceiveMessageFrom-bug
Feb 2, 2021
Merged

Respect offset in Socket.ReceiveMessageFrom(saea) on Windows#47642
antonfirsov merged 7 commits into
dotnet:masterfrom
antonfirsov:sockets/ReceiveMessageFrom-bug

Conversation

@antonfirsov

@antonfirsov antonfirsov commented Jan 29, 2021

Copy link
Copy Markdown
Contributor

Fixes #47637, and also adds an equivalent test for ReceiveFrom as an extra.

/cc @geoffkizer @wfurt

@ghost

ghost commented Jan 29, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #47637, and also adds an equivalent test for ReceiveFrom as an extra.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Sockets

Milestone: -

@antonfirsov

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@wfurt wfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

# Conflicts:
#	src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveMessageFrom.cs
@antonfirsov

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov antonfirsov merged commit f47c1b5 into dotnet:master Feb 2, 2021
@geoffkizer

Copy link
Copy Markdown
Contributor

Wow, ugly. Thanks for finding and fixing.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Socket.ReceiveMessageFrom(saea) does not respect buffer offset on Windows

4 participants