More arities for tuple returning zip extension method#47147
Conversation
ghost
added
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @eiriktsarpalis Issue DetailsCloses #43702 It grows exponentially for test exhaustiveness. I'm just focusing on the third parameter.
|
eiriktsarpalis
left a comment
eiriktsarpalis
left a comment
There was a problem hiding this comment.
Looks great, thank you for the contribution!
| public static MethodInfo Zip_TFirst_TSecond_TThird_3(Type TFirst, Type TSecond, Type TThird) => | ||
| (s_Zip_TFirst_TSecond_TThird_3 ?? | ||
| (s_Zip_TFirst_TSecond_TThird_3 = new Func<IQueryable<object>, IEnumerable<object>, IEnumerable<object>, IQueryable<(object, object, object)>>(Queryable.Zip).GetMethodInfo().GetGenericMethodDefinition())) | ||
| .MakeGenericMethod(TFirst, TSecond, TThird); |
There was a problem hiding this comment.
I was going to comment saying ??= could be used to simplify this, but I see you're just following the pattern used in a bunch of other cases above. We can clean it up later.
Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
|
Thanks for the contribution! |
|
Thank you! In which runtime version is this feature supposed to be available? |
|
That would be released with .NET 6 next November. |
4 participants
Closes #43702
It grows exponentially for test exhaustiveness. I'm just focusing on the third parameter.