[wasm][tests] Log messages with the correct log level#43115
Conversation
.. the original messages. Instead of sending the message as is from,
say, `console.log`, we send:
`{ method: 'console.log', payload: message }`
.. which gets parsed, and logged accordingly.
Also, fix printErr to use `console.error`.
|
Tagging subscribers to this area: @maryamariyan |
|
Corresponding XHarness PR: dotnet/xharness#328 |
| return function(_msg) { | ||
| window.real_print(JSON.stringify({ | ||
| method: `console.${level}`, | ||
| payload: _msg |
There was a problem hiding this comment.
Thoughts on passing all the args?
| payload: _msg | |
| payload: [...arguments] |
There was a problem hiding this comment.
If there is more than one argument, then how should that be logged? as the json array itself, so [ "arg1", 5, {x: 4} ]?
There was a problem hiding this comment.
There was a problem hiding this comment.
preserve as much fidelity as you can?
There was a problem hiding this comment.
Basically we treat console as an object so something like
realConsole[method](...payload);
There was a problem hiding this comment.
consider:
var message = "time";
var domain = "fun";
var fmt = "%s %s";
console.log (fmt, domain, message);
// or console.log("%s %s", "fun", "time");the output should be
fun time
it is currently
%s %s
There was a problem hiding this comment.
so
var payload = ["%s %s", "fun", "time"];
var method = "log";
console[method](...payload);outputs
fun time
| printErr = console.error; | ||
|
|
||
| // JavaScript core does not have a console defined | ||
| if (typeof console === "undefined") { |
There was a problem hiding this comment.
Is this check still relevant or should this be put on top?
Because now console gets also accessed if is_browser is false before this line.
If this gets changed it will conflict with #43002
There was a problem hiding this comment.
We should move all the console polyfill bits to the top I think, it is getting pretty messy
|
Tagging subscribers to this area: @directhex |
ghost
locked as resolved and limited conversation to collaborators
6 participants
No description provided.