Skip to content

Changing the free list from singly linked to doubly linked #43021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maoni0 merged 1 commit into from
Oct 6, 2020
Merged

Changing the free list from singly linked to doubly linked #43021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/coreclr/src/gc/env/gcenv.object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,11 @@ class Object

MethodTable * GetGCSafeMethodTable() const
{
#ifdef HOST_64BIT
return (MethodTable *)((uintptr_t)m_pMethTab & ~7);

@jkotas jkotas Oct 5, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also need update in https://github.com/dotnet/diagnostics/blob/2e2e6775d46a31e44218d62657b4169fa13ac74d/src/SOS/Strike/sos.cpp#L122 and potentially other places that have this mask hardcoded.

@Maoni0 Maoni0 Oct 6, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jkotas! we will be sure to change this (in another PR). for now I wanted to check this in so Peter can continue working on it while I take care of some other urgent workitem.

#else
return (MethodTable *)((uintptr_t)m_pMethTab & ~3);
#endif //HOST_64BIT
}

void RawSetMethodTable(MethodTable * pMT)
Expand Down
Loading