[wasm][filesystem] add arg to testharness for setting working dir#42020
Merged
Conversation
Dotnet-GitSync-Bot
added
the
area-Infrastructure-coreclr
radical
reviewed
Sep 14, 2020
…irectory - This test was failing because it checks for `Path.GetFileName(Directory.GetCurrentDirectory())` which returns `""` for cwd==`"/"`. - So, we add a dummy directory to the output, and use a new `--working-dir` argument to set that as the cwd. - And this is passed to the runtests script via a new msbuild property called `$(RunTestsJSArguments)`
lewing
reviewed
Sep 16, 2020
| runtime_args = []; | ||
| enable_gc = true; | ||
| enable_zoneinfo = false; | ||
| working_dir='/'; |
Member
There was a problem hiding this comment.
what is the default working_dir generall?
Member
There was a problem hiding this comment.
I tried printing cwd for other tests, and it was /.
Member
There was a problem hiding this comment.
I mean, we weren't setting it at all. And FS.cwd said /
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #39998