Port corclr 27875#42
Merged
Merged
Conversation
Member
|
@jashook the formatting jobs are still failing here, is this expected? |
Contributor
Author
|
The job is actually working correctly in the change. A last minute coreclr change broke our formatting rules. I am applying the patch here and will merge through this change. |
Member
|
Not sure I follow. You are saying that you will submit another commit on-top of the existing one or that the failing legs aren't actually failing? |
Contributor
Author
|
The failure is expected because the jit sources are not formatted correctly. |
Contributor
Author
|
I will submit another commit which applies the patch, fixing the format. |
Member
|
thanks! |
Contributor
Author
|
Formatting passed, merging to save resources. |
ghost
locked as resolved and limited conversation to collaborators
PureWeen
pushed a commit
to dotnet/maui
that referenced
this pull request
Jun 11, 2026
…R-side tristate Addresses adversarial review findings from Opus / GPT-5.5 / Gemini-3.1-Pro: 1. CRITICAL — Get-TagsForMilestone derives major from $Milestone arg, not from $script:validationMajor. Pre-fix, validating a net11.0 PR with an issue currently milestoned '.NET 10 SR6' filtered out every 10.x tag (because validationMajor=11), making Test-PrShippedInMilestone return false, which silently clobbered SR6 — the exact data-loss case the KEEP guard exists to prevent. (Opus) 2. CRITICAL — Restricted Get-LinkedIssues and Test-MilestoneValidForIssue cross-repo prefix from [A-Za-z0-9_\-./]+ to '(?:dotnet/maui)?'. The old regex silently matched 'Fixes dotnet/runtime#42' and would have closed unrelated MAUI #42. Mirrors GitHub's own auto-close scope. (GPT-5.5 + Gemini-3.1-Pro) 3. Replaced two-query foreach in Test-MilestoneValidForIssue with a single OR query ('#N in:title,body OR issues/N in:body'). Halves Search API consumption (30 req/min limit was hit after 16 issues) and eliminates the 'discard positive evidence on partial failure' trap. Also removed $null caching so a transient failure no longer permanently disables KEEP for that pair. (Gemini-3.1-Pro + Opus) 4. PR-side tristate: Get-PrsInTag returns $null on git failure (was @()); Test-PrShippedInMilestone propagates that through to Test-MilestoneValidForPr. Test-AndRecordCorrection already had defensive $null handling for issues; now it applies equally to PRs (cherry-pick KEEP path). One transient git failure no longer silently clobbers a valid earlier milestone. (Opus) Also added unary-comma fix to Get-PrsInTag's HashSet return so PowerShell doesn't unwrap single-element collections (caller relies on .Contains()). Tests: 134 → 149 (+15). New coverage: - Get-TagsForMilestone cross-major behavior (the missing test that hid the bug) - Three NEGATIVE cases for cross-repo regex (dotnet/runtime, xamarin, mixed) - Single OR query string assertion + caching test updated to 1 call - Test-PrShippedInMilestone tristate ($true / $false / $null cases) - Test-AndRecordCorrection PR-side $null → skip correction Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.