[browser][wasm] Fix assembly name not found due to rename of assembly.#41037
Merged
Conversation
kjpou1
changed the title
Member
|
Please confirm if these tests are now passing in the CI checks after this change prior to merging. |
SamMonoRT
approved these changes
Aug 20, 2020
Contributor
Author
|
This just changes the assembly name and not turning the tests on. There is still work being done to ensure these tests are passing in other PR's. |
Member
|
LGTM if enabling the tests is done via a separate PR. Add a note regarding that PR/issue details or link that issue here for visibility. |
Contributor
Author
|
Here is the active issue that turns the tests off. #40112 Updated the main issue comments that this does not turn the tests back on and will be handled later. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the renaming of the assembly System.Runtime.InteropServices.JavaScript to System.Private.Runtime.InteropServices.JavaScript the marshal tests will fail once they are turned back on.
This PR does not reactivate the tests only fixes a problem that will be presented in the future if someone is working on those tests in the future.
The active issue that turns off those tests is #40112. Once this issue is addressed then the tests can be turned back on.
Closes #41036