-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Intrinsicify JsonReaderHelper.IndexOfOrLessThan #40877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6fb8886
x86, x64, ARM Intrinsicify JsonReaderHelper.IndexOfOrLessThan
benaadams 19facfe
Add optimization for wasm
benaadams 5635864
Add IncludePlatformAttributes
benaadams c2de3f7
try adding framework
benaadams 654a69e
multi-framework
benaadams 53a145d
BuildTargetFramework
benaadams d3f1254
Try including Directory.Build.props
benaadams 59c60ec
Feedback
benaadams bd953a7
TargetFramework filter
benaadams f13fe7a
Output trimming subtask binlog
benaadams 59dc0d5
Add to Build.props
benaadams b6bcfaa
paths
benaadams bc5e9cd
Import
benaadams d4f1078
Conditional
benaadams d4cdcc6
path
benaadams 51acd99
path
benaadams f6b1790
path
benaadams 53afcd8
path
benaadams 541a856
Try static restore
benaadams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
src/libraries/System.Text.Json/src/System/Text/Json/Reader/JsonReaderHelper.SizeOpts.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Runtime.CompilerServices; | ||
|
|
||
| namespace System.Text.Json | ||
| { | ||
| internal static partial class JsonReaderHelper | ||
| { | ||
| // https://tools.ietf.org/html/rfc8259 | ||
| // Does the span contain '"', '\', or any control characters (i.e. 0 to 31) | ||
| // IndexOfAny(34, 92, < 32) | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public static int IndexOfQuoteOrAnyControlOrBackSlash(this ReadOnlySpan<byte> span) | ||
| { | ||
| for (int i = 0; i < span.Length; i++) | ||
| { | ||
| int value = span[i]; | ||
| if (value == JsonConstants.Quote || value == JsonConstants.BackSlash || JsonConstants.Space > value) | ||
| return i; | ||
| } | ||
|
|
||
| return -1; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.