WIP: Initial CoreCLR CI pipeline in the composite repo#4
Closed
trylek wants to merge 10000 commits intodotnet:masterfrom
trylek:InitialCoreCLRCIPipeline
Closed
WIP: Initial CoreCLR CI pipeline in the composite repo#4trylek wants to merge 10000 commits intodotnet:masterfrom trylek:InitialCoreCLRCIPipeline
trylek wants to merge 10000 commits intodotnet:masterfrom
trylek:InitialCoreCLRCIPipeline
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(*) I had to temporarily put back the myget feed because, without it,
we cannot restore Microsoft.DotNet.CoreCLR.TestDependencies;
(*) I temporarily deleted an MSBuild execution in eng/Build.props
that was causing issues – haven’t yet retested after Viktor’s most
recent changes, may be theoretically fixed;
(*) Bumped up MicrosoftPrivateCoreFxNETCoreAppPackageVersion fixes
build of several tests hitting contract mismatches (ARM HW tests,
SuppressGCTransition attributes);
(*) Temporarily removed setup of stress dependencies that hits
trouble when restoring CoreDisTools in the absence of myget feed;
(*) Temporarily downgrated R2RDump to use 00001 version of CoreDisTools
as 00005 is only available on myget – this will likely need resolving
as R2RDump actually needs the newer version (and so does stress
dependency setup);
(*) Most of the remaining issues are just the path tweaks that fall
into four categories - cmd, sh, proj, yml. Based on Viktor's advice
I have a relatively good idea what to do about cmd, sh and proj,
I haven't yet thought about yml (in fact I haven't yet seen the
change in its entirety as a PR to get a better overview).
Thanks
Tomas
P.S. "tiny.yml" is the minimalistic pipeline. Of course I expect
this to be only temporary. I used a second branch with a manual fix
to the pipeline to run Windows_NT instead of OSX so that I didn't
have to create two different pipelines.