Skip to content

[Wasm] Enable System.Data.Common tests#39463

Merged
akoeplinger merged 6 commits into
dotnet:masterfrom
steveisok:wasm-sys-data-common
Aug 4, 2020
Merged

[Wasm] Enable System.Data.Common tests#39463
akoeplinger merged 6 commits into
dotnet:masterfrom
steveisok:wasm-sys-data-common

Conversation

@steveisok

@steveisok steveisok commented Jul 16, 2020

Copy link
Copy Markdown
Member

Disable the tests that require SQL Server.

@ghost

ghost commented Jul 16, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @roji, @ajcvickers
Notify danmosemsft if you want to be subscribed.

@steveisok steveisok added the arch-wasm WebAssembly architecture label Jul 16, 2020
@MaximLipnin

Copy link
Copy Markdown
Contributor

#38963

@roji

roji commented Jul 17, 2020

Copy link
Copy Markdown
Member

@steveisok is it possible to get a bit of context on why the DbProviderFactories and DataView APIs aren't supported on WASM?

@steveisok

Copy link
Copy Markdown
Member Author

Not sure the official reason. I was carrying it over from mono/mono.

I suspect the reason for DbProviderFactories may be to really safeguard you from running into a wall w/ SqlClient ;-). That's just not going to work through a browser.

@ajcvickers

Copy link
Copy Markdown
Contributor

@steveisok On the other hand, the SQLite ADO.NET provider already works on WASM, so any decisions here should not be based on whether or not the SQL Server ADO.NET provider will work. ADO.NET in general should work.

@steveisok

Copy link
Copy Markdown
Member Author

@lewing Do you have any insight on this?

@lewing

lewing commented Jul 18, 2020

Copy link
Copy Markdown
Member

@ajcvickers we don't want to break things needlessly but we want to make sure the use experience is good, can you help with guidance here?

@roji

roji commented Jul 18, 2020

Copy link
Copy Markdown
Member

In principle, I don't see a reason not to allow using DbProviderFactories, DataView or anything else that's under System.Data - these APIs seem to be implemented in pure .NET (no native dependencies or similar), and as @ajcvickers they can be used just like on .NET Core to work with Sqlite. It's possible that mono simply has/had a somewhat outdated implementation of DbProviderFactories.

There are also various other database providers out there, which may or may not work with WASM. I don't think we need to do anything in System.Data itself to block anything - whether a provider works or not should be their issue.

@lewing

lewing commented Jul 20, 2020

Copy link
Copy Markdown
Member

Ok I think we'll roll back the PNSE and just disable the tests that require SQL Server.

@akoeplinger akoeplinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just one comment.

Comment thread src/libraries/System.Data.Common/tests/SuitePlatformDetection.cs Outdated
@akoeplinger akoeplinger changed the title [Wasm] Enable System.Data.Common tests and PNSE a few types [Wasm] Enable System.Data.Common tests Aug 4, 2020
@akoeplinger akoeplinger merged commit 0bd3ae0 into dotnet:master Aug 4, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
Disable the tests that require SQL Server.

Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
Co-authored-by: Maxim Lipnin <v-maxlip@microsoft.com>
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-System.Data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants