Run wasm tests on Helix#37752
Merged
Merged
Conversation
…to prvysoky/use-helix-sdk
None of these fixes are wrong per se (maybe the ApkBuilder changes?) but they complicate the PR by mixing unrelated changes
This reverts commit d1a4226.
This reverts commit 64da851.
…"" This reverts commit 506afd2.
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
steveisok
self-requested a review
June 19, 2020 22:06
steveisok
approved these changes
Jun 19, 2020
Member
|
Taking a final look. |
safern
approved these changes
Jun 19, 2020
premun
reviewed
Jun 22, 2020
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
This reverts commit afaffb8.
Member
|
Wuhu 🎉 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see what happens. Based on latest iOS PR.