Skip to content

Revert "Update "LICENSE.txt" so that it's recognized as MIT"#37626

Merged
stephentoub merged 2 commits into
masterfrom
revert-36744-patch-1
Jun 9, 2020
Merged

Revert "Update "LICENSE.txt" so that it's recognized as MIT"#37626
stephentoub merged 2 commits into
masterfrom
revert-36744-patch-1

Conversation

@stephentoub

@stephentoub stephentoub commented Jun 9, 2020

Copy link
Copy Markdown
Member

Reverts #36744

All PRs to dotnet/runtime are now failing with:

error : License file content '/Users/runner/runners/2.169.1/work/1/s/LICENSE.TXT' doesn't match the expected license '/Users/runner/runners/2.169.1/work/1/s/.packages/microsoft.dotnet.arcade.sdk/5.0.0-beta.20280.1/tools/Licenses/MIT.txt'.

cc: @richlander, @terrajobst, @jkotas

@ghost

ghost commented Jun 9, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@stephentoub

Copy link
Copy Markdown
Member Author

(@ViktorHofer, if changes to LICENSE.TXT can cause builds to fail, we need to ensure at least one relevant CI leg runs when it's changed.)

@safern

safern commented Jun 9, 2020

Copy link
Copy Markdown
Member

@stephentoub I pushed to this branch if that's OK to add that validation. If we want to keep it as a separate change I can of course put it in a new PR.

@safern

safern commented Jun 9, 2020

Copy link
Copy Markdown
Member

Feel free to merge in order to unblock PRs if you're OK with me adding the change to run the global build on PRs here.

@stephentoub stephentoub merged commit ed3d384 into master Jun 9, 2020
@stephentoub stephentoub deleted the revert-36744-patch-1 branch June 9, 2020 02:22
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants