Implement ModuleBuilder.GetFieldToken#37497
Merged
alexischr merged 1 commit intoJun 8, 2020
Merged
Conversation
alexischr
requested review from
EgorBo,
akoeplinger,
marek-safar,
steveisok and
vargaz
as code owners
100 tasks
Contributor
Author
|
There are no tests for this; It is only used internally by CoreCLR's ModuleBuilder, and Mono's version does not use it. This does help in eventually replacing Mono's ModuleBuilder with CoreCLR's. |
marek-safar
approved these changes
Jun 8, 2020
marek-safar
left a comment
marek-safar
left a comment
Contributor
There was a problem hiding this comment.
It's public API so it's odd there are no tests
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure why this was not filled in, ModuleBuilder has support for
FieldBuilderpseudo-tokens in the same file, and support forRuntimeFieldInfoinsre.c:mono_image_create_token.Contributes to mono/mono#14788