Skip to content

Respect Process.SynchronizingObject in Process events#37308

Merged
stephentoub merged 2 commits into
dotnet:masterfrom
stephentoub:fixprocessinvoke
Jun 9, 2020
Merged

Respect Process.SynchronizingObject in Process events#37308
stephentoub merged 2 commits into
dotnet:masterfrom
stephentoub:fixprocessinvoke

Conversation

@stephentoub

@stephentoub stephentoub commented Jun 2, 2020

Copy link
Copy Markdown
Member

@ghost

ghost commented Jun 2, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @eiriktsarpalis
Notify danmosemsft if you want to be subscribed.

@adamsitnik adamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing this @stephentoub !

Comment thread src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs Outdated
Comment thread src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs Outdated
Comment thread src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Outdated
Comment thread src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Outdated
Comment thread src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Outdated
@stephentoub stephentoub merged commit d3d9a91 into dotnet:master Jun 9, 2020
@stephentoub stephentoub deleted the fixprocessinvoke branch June 9, 2020 00:14
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Process.OutputReadNotifyUser does not respect the synchronization context when invoking DataReceivedEventHandler

4 participants