Redesign the subset feature

[ViktorHofer]

Fixes #34403

Part of yesterday's batched rollout: #33821. I'll send out a mail to the team for the updated workflow instructions.

[ghost]

Tagging @ViktorHofer as an area owner

[trylek]

Looks great to me, thank you!

[vcsjones]

I'll send out a mail to the team for the updated workflow instructions.

Will this affect contributors? If so, can some of the workflow changes be shared somewhere?

[safern]

Will this affect contributors? If so, can some of the workflow changes be shared somewhere?

I think every rollout date is going to be reminded on the gitter channel with the changes for that rollout.

[ViktorHofer]

Will this affect contributors? If so, can some of the workflow changes be shared somewhere?

Yes, I pinned #33821 to make sure that community members know about the planned changes as well which also list the impact and the new workflow. In addition to that after this is merged I'll notify the gitter channel. The docs will be updated as part of this PR as well. Anything you are missing here?

[vcsjones]

pinned #33821

Anything you are missing here?

I guess eyes. Apologies for missing that (or perhaps I saw it and forgot about it, that sounds like something I'd do, too).

[ViktorHofer]

We are doing this the first time (batched rollout + announcements) so there's definitely room for improvement. FWIW I just posted a little announcement in the gitter channel.

[ViktorHofer]

Merging as CI seems to be busted and I verified the changes with the existing legs.

[tmds]

@ViktorHofer I think this is a nice improvement. 👍

It seems the -subset argument needs to be specified, though the examples in #34403 didn't have it, e.g.:

./build.sh libs+clr

Is this due to a parsing limitation in the script?

nit: the documentation mixes use of -subset and --subset. It would be nice to pick one and use it consistently.

[danmoseley]

cc @safern for question above as @ViktorHofer is out rest of week.

[safern]

Is this due to a parsing limitation in the script?

Right now it needs to be passed only for bash. I'm working on fixing that -- but yeah initially was because of a limitation in the script.