Introduce native AssemblyLoadContext base class#32097
Merged
Merged
Conversation
jkotas
changed the title
jkotas
commented
Feb 11, 2020
| // Unmanaged counter-part of System.Runtime.Loader.AssemblyLoadContext | ||
| // | ||
| class AssemblyLoadContext : public IUnknownCommon<ICLRPrivBinder, IID_ICLRPrivBinder> | ||
| { |
Member
Author
There was a problem hiding this comment.
These is a lot more that can move here eventually.
MichalStrehovsky
approved these changes
Feb 11, 2020
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
Member
There was a problem hiding this comment.
Looks good to me, but I'm no expert in this codebase. Thank you!
elinor-fung
approved these changes
Feb 11, 2020
elinor-fung
left a comment
elinor-fung
left a comment
Member
There was a problem hiding this comment.
I'm actually unclear how we decide (decided?) where binder-related code should live (even the three binder implementations are split between binder and vm right now), so my only question would be why the new AssemblyLoadContext base should go under vm versus binder.
Member
Author
|
I think we should work on making binder directory, ICLRPrivBinder, etc. to go away. Ideally, the low-level details like |
Member
Author
|
Failures are known issue #32126 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.