Vector abi tests#32034
Merged
Merged
Conversation
- Anticipated work on Windows Amd64 calling conventions may affect this, so this needs testing
jkoritzinsky
approved these changes
Feb 10, 2020
- Adjust some reverse p/invoke struct marshalling tests to add coverage for returning structures - Coverage includes a 3 byte, 4 byte struct, 8 byte struct, and a large struct - Note: There is a code in mlinfo.cpp which explicitly makes support for returning 3, 5, 6, and 7 on X86 follow the wrong calling convention by rounding the size to a 4 byte boundary. I've left this unfortunate detail in place. - Fix issues noted in returning structures from reverse p/invokes
jkoritzinsky
approved these changes
Feb 13, 2020
jkoritzinsky
left a comment
jkoritzinsky
left a comment
Member
There was a problem hiding this comment.
The ReversePInvokeTest.cs file is showing up as binary for some reason. Once that's changed to text, this looks good to me!
Member
Author
|
Previously this passed CI, and the only change was a change to move a test from being encoded Utf16 to Utf8. |
Contributor
|
cc @CarolEidt |
Contributor
|
fyi, this led to new JIT assertion failures: #32379 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for marshalling Vector2, Vector3, and Vector4 to and from native code