Repository navigation
[release/10.0] Fix msl wait time extraction in GC - #135228
Merged
JulieLeeMSFT merged 1 commit intoOct 5, 2026
Merged
JulieLeeMSFT merged 1 commit into
JulieLeeMSFT merged 1 commit into
Conversation
Backport of dotnet#135022, adapted to gc.cpp before the GC source-file split. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f6205bb0-b7d2-47d7-bf83-96ed19e7b932
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
JulieLeeMSFT
added
Servicing-approved
Member
|
/ba-g known issue. |
JulieLeeMSFT
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #135022 to release/10.0
/cc @janvorli
Customer Impact
There is a bug in the
gc_heap::get_msl_wait_timeimplementation that was introduced in .NET 9. The function has two output argumentssoh_msl_wait_timeanduoh_msl_wait_time, but instead of updating the values these args point to, it updates the args themselves. So it never reads out any value.These values influence DATAS calculatation of throughput cost, which influences Gen0 allocation budgets and heap count adaptation.
Regression
Testing
Coreclr and libraries tests.
Risk
Low, it is a trivial change that just fixes the extraction of msl wait time values by get_msl_wait_time extracts.