Skip to content

JIT: remove unused helpers - #135026

Merged
EgorBo merged 1 commit into
dotnet:mainfrom
EgorBo:jit-remove-dead-shared-helpers
Oct 1, 2026
Merged

EgorBo merged 1 commit into
dotnet:mainfrom
EgorBo:jit-remove-dead-shared-helpers

Conversation

@EgorBo

@EgorBo EgorBo commented Oct 1, 2026

Copy link
Copy Markdown
Member

No description provided.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 4119d093-350c-4187-aa05-c7779793e89f
@EgorBo
EgorBo requested a balanced review from Copilot October 1, 2026 15:02
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 1, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The removals are internally scoped, consistent across declarations and definitions, and have no remaining references.

Review effort: Balanced
Findings: None

What changed in this PR

Removes unused JIT helpers and disabled EH normalization code without changing active behavior.

Changes:

  • Deletes unused floating-point, layout, bit-vector, scope, and code-generation helpers.
  • Removes unused profile-synthesis modes.
  • Simplifies EH normalization documentation and verification.
File Description
utils.h Removes unused floating-point declarations.
utils.cpp Removes corresponding implementations.
layout.cpp Removes unused numeric layout identifiers.
jiteh.cpp Deletes disabled EH normalization case 3.
hashbv.h Removes unused bit-vector APIs and freelist state.
hashbv.cpp Removes their implementations.
fgprofilesynthesis.h Removes unused synthesis options.
fgprofilesynthesis.cpp Removes unused likelihood transformations.
compiler.h Removes obsolete declarations.
compiler.cpp Removes an unused scope-processing helper.
codegenlinear.cpp Removes unused block-operation helpers.
codegencommon.cpp Removes unused register push/pop helpers.
codegen.h Removes corresponding declarations.

@EgorBo

EgorBo commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

cc @dotnet/jit-contrib (should be 100% unused code), no diffs.

@EgorBo

EgorBo commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

/ba-g #135031

@EgorBo
EgorBo enabled auto-merge (squash) October 1, 2026 18:19
@EgorBo
EgorBo merged commit 632fba0 into dotnet:main Oct 1, 2026
138 of 140 checks passed
@EgorBo
EgorBo deleted the jit-remove-dead-shared-helpers branch October 1, 2026 18:19
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants