Remove a couple of static constructors/static readonly fields in corelib - #134993
Merged
Merged
Conversation
…eLib types Convert private/internal static readonly fields initialized with constant data into RVA-backed ReadOnlySpan<T> properties, consts or JIT-foldable properties to avoid static constructors and startup allocations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a446a36-3c8d-493e-85b6-3877722d004b
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-meta |
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
Member
There was a problem hiding this comment.
LGTM. Maybe Tanner should look at the decimal changes.
jkotas
reviewed
Oct 1, 2026
This was referenced Oct 1, 2026
Open
- Inline typeof(...) in RuntimeType instead of ValueType/ObjectType/StringType properties (and drop the Mono copies). - Call Array.Empty<object>() directly from DelegateInvokeObjectArrayThunk and delete DelegateHelpers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a446a36-3c8d-493e-85b6-3877722d004b
MichalStrehovsky
approved these changes
Oct 1, 2026
This was referenced Oct 1, 2026
Member
Author
|
Btw, @MichalStrehovsky this only a small subset of what can be done.
But I haven't reviewed any of them yet, just as a hint that apparently there are many places to fix |
tannergooding
approved these changes
Oct 1, 2026
Member
Author
|
/ba-g failure is #135014 |
EgorBo
enabled auto-merge (squash)
October 1, 2026 17:12
Member
Looks good to me overall - feel free to submit all of them as one PR, I will be happy to review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert private/internal static readonly fields initialized with constant data into RVA-backed ReadOnlySpan properties, consts or JIT-foldable properties to avoid static constructors and startup allocations.