Skip to content

JIT: Preserve finalizable allocations during hoisting - #134971

Merged
EgorBo merged 2 commits into
dotnet:mainfrom
EgorBo:fix-134936-finalizable-allocation-hoisting
Oct 1, 2026
Merged

EgorBo merged 2 commits into
dotnet:mainfrom
EgorBo:fix-134936-finalizable-allocation-hoisting

Conversation

@EgorBo

@EgorBo EgorBo commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Treat allocator calls with observable allocation side effects as an ordering barrier for later throwing expressions.Fixes #134936

Diffs

Treat allocator calls with observable allocation side effects as an ordering barrier for later throwing expressions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 30, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@EgorBo
EgorBo requested a review from adamperlin September 30, 2026 20:45
@EgorBo

EgorBo commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

PTAL @adamperlin @dotnet/jit-contrib almost no diffs

@EgorBo

EgorBo commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

@adamperlin could you please re-approve? I had to disable the new test for Mono

@EgorBo
EgorBo requested a review from adamperlin October 1, 2026 16:40
@EgorBo

EgorBo commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

/ba-g #135031

@EgorBo
EgorBo merged commit cac7e62 into dotnet:main Oct 1, 2026
142 of 144 checks passed
@EgorBo
EgorBo deleted the fix-134936-finalizable-allocation-hoisting branch October 1, 2026 18:21
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JIT: (bug) loop hoisting moves a throwing idiv above a finalizable object allocation

2 participants