Use internal metadata interfaces in CoreCLR - #134875
Merged
davidwrighton merged 4 commits intoOct 1, 2026
Merged
Conversation
Avoid legacy public metadata import and emit interfaces when profiler support is disabled, and migrate Reflection.Emit to the internal metadata surface. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
jkotas
reviewed
Sep 29, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2 tasks
jkotas
reviewed
Sep 30, 2026
jkotas
reviewed
Sep 30, 2026
3 tasks
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
davidwrighton
marked this pull request as ready for review
September 30, 2026 22:16
jkotas
approved these changes
Sep 30, 2026
jkotas
reviewed
Sep 30, 2026
jkotas
reviewed
Sep 30, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jkotas
approved these changes
Oct 1, 2026
Member
Author
|
/ba-g failing tests are known, and fixed while this PR was open, so the failures are expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IMDInternalImportandIMDInternalEmitPEAssemblyinstances and keep public VM bridges only in profiler-enabled buildsRegMetabuilds without profiler support while retaining them for profiler, DAC, DBI, and portable-PDB targetsMDTOKENMAPto the sparse source-token movement map needed by desktop persistence and remove unused metadata lookup helpersE_NOTIMPLfrom the CoreCLR copies of internal APIs used only by ILAsm or ILDasm while retaining their implementations in the portable-PDB tool flavorFEATURE_ISYM_READERis enabledWebAssembly size
Measured with
./build.sh -os browser -c Release -subset clr+libsagainst a clean worktree atbae5a8d2f1913c45bd474fdbecb17d572e235a4c.dotnet.native.wasmdotnet.native.wasm(gzip -9)corerun.wasmcorerun.wasm(gzip -9)The final Emscripten symbol map contains no public
IMetaDataTables,IMetaDataTables2, orIMetaDataInfoimplementation; metadata persistence implementation; removedMDTOKENMAPmodes or lookup helpers; or full CoreCLR implementation of the two tool-only APIs. Required interface slots remain as nine-byteE_NOTIMPLstubs.Testing
./build.sh clr+libs+host— passed with 0 warnings and 0 errors./build.sh -os browser -c Release -subset clr+libs— passed with 0 warnings and 0 errors./dotnet.sh build src/libraries/System.Reflection.Emit/tests/System.Reflection.Emit.Tests.csproj -t:Test -p:TargetArchitecture=x64 -p:Configuration=Debug— 2,640 passed, 0 failed, 0 skippedNote
This pull request description was generated with GitHub Copilot.