Repository navigation
[browser][trimmed] Fix DI generic constraint tests conflicting with trimmability validation - #134760
Merged
Merged
Conversation
When PublishTrimmed is set, ILLink defaults VerifyDependencyInjectionOpenGenericServiceTrimmability to true, causing CallSiteFactory to reject the open-generic registrations that CallSiteFactoryTest deliberately uses. Opt the test project out and re-enable the affected tests. VerifyOpenGenericTrimmabilityChecks still enables the switch explicitly via RemoteExecutor. Fixes #134266 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection |
jkotas
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause: When
PublishTrimmedis set,src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targetsdefaultsVerifyDependencyInjectionOpenGenericServiceTrimmabilitytotrue, which enables theMicrosoft.Extensions.DependencyInjection.VerifyOpenGenericServiceTrimmabilityfeature switch.CallSiteFactory.ValidateTrimmingAnnotationsthen rejects the open-generic registrations that theseCallSiteFactoryTestcases deliberately use (implementation constraints the service type lacks), so container construction throwsArgumentException. This is intended validation, not missing metadata.Fix: The DI test project opts out of the default, and the five
ActiveIssueattributes are removed. The only test that needs the switch on,VerifyOpenGenericTrimmabilityChecks, sets it explicitly through RemoteExecutorRuntimeConfigurationOptions, so its coverage is unchanged. It's also skipped wherever RemoteExecutor is unsupported, including browser.Validation: browser-wasm CoreCLR Release,
Microsoft.Extensions.DependencyInjection.TestswithEnableAggressiveTrimming=true TestTrimming=trueon Chrome: 884 tests, 847 passed, 37 skipped, 0 failed. All 7 re-enabled cases (4 facts + 3 theory rows) passed, and the publishedruntimeconfig.jsonshows the switch asfalse. The issue reports the same failure on Mono browser trimming; only CoreCLR was run locally.Resolves #134266
Note
This PR was generated with GitHub Copilot assistance.