Skip to content

[browser][CoreCLR] Root UnloadableAssembly so trimmed builds keep it for AssemblyGetForwardedTypesLoadFailure #134759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewing merged 3 commits into from
Sep 28, 2026
Merged

[browser][CoreCLR] Root UnloadableAssembly so trimmed builds keep it for AssemblyGetForwardedTypesLoadFailure #134759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b4411d
Root UnloadableAssembly in System.Reflection.Tests ILLink descriptor
lewing Sep 27, 2026
c2104d8
Remove Apple CoreCLR ActiveIssue on AssemblyGetForwardedTypesLoadFailure
lewing Sep 27, 2026
f593043
Apply suggestion from @lewing
lewing Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,9 +958,6 @@ public static void AssemblyGetForwardedTypes()

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69919", typeof(PlatformDetection), nameof(PlatformDetection.IsNativeAot))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/77821", TestPlatforms.Android)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/134263", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
public static void AssemblyGetForwardedTypesLoadFailure()
{
Assembly a = typeof(TypeInForwardedAssembly).Assembly;
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Runtime/tests/System.Reflection.Tests/ILLink.Descriptors.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,7 @@
</assembly>
<assembly fullname="System.Runtime" />
<assembly fullname="ForwardedTypesAssembly" />
<!-- Only referenced through a type forwarder in ForwardedTypesAssembly; AssemblyGetForwardedTypesLoadFailure expects it to exist and fail to load. -->
<assembly fullname="UnloadableAssembly" />
<assembly fullname="TestAssembly" />
</linker>
Loading