Repository navigation
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics-tensors |
This was referenced Sep 27, 2026
Open
Contributor
Author
|
fixed in #134914 |
Member
|
Sorry for both the delay and not directly looking at this one. There was a number of issues and reports and they needed to be handled end to end, so it was easier to do my own audit and fixes to get everything in "one go". There's still a couple other minor edges I'm fixing and then separately a perf PR that will be going up. |
Contributor
Author
|
No worries at all! Thanks for the explanation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tensor<T>.GetPinnableReference()returned a reference to the first element of the backing array without accounting for the slice's starting offset. As a result, pinning a non-zero-offset slice could expose the parent array's data instead of the slice's data.Fix
Updated
GetPinnableReference()to apply the tensor slice's_startoffset usingUnsafe.Add:GetPinnedHandle()already usesGetPinnableReference(), so no changes were required there.Tests
Added a regression test covering a non-zero-offset tensor slice. The test verifies that:
GetPinnableReference()points to the first element of the slice.GetPinnedHandle()exposes the expected slice data.closes #134691.