Repository navigation
Build macOS Arm64 artifacts for M4 performance runs - #134616
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Exclude internal release branches from the macOS Arm64 build guard.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds opt-in macOS Arm64 CoreCLR artifacts for M4 performance runs.
Changes:
- Adds
osx_arm64support to the CoreCLR performance template. - Enables it for non-release performance builds.
- Reuses existing cross-build and artifact-upload paths.
| File | Description |
|---|---|
eng/pipelines/performance/templates/perf-coreclr-build-jobs.yml |
Adds macOS Arm64 platform support and artifact publishing. |
eng/pipelines/performance/templates/perf-build-jobs.yml |
Enables macOS Arm64 builds outside release branches. |
LoopedBard3
approved these changes
Sep 29, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d3ea3c9-20b5-43c5-8e73-5a61a2120de9
Disable WASM and non-Mac runtime builds for M4 queue validation. Revert this commit after the trial. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d3ea3c9-20b5-43c5-8e73-5a61a2120de9
Remove the unnecessary build-side branch guard. Keep the shared performance run guard for release branches without Mac build support. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d3ea3c9-20b5-43c5-8e73-5a61a2120de9
DrewScoggins
force-pushed
the
add-m4-perf-build
branch
from
September 30, 2026 00:00
c8bb1f5 to
c1419a4
Compare
DrewScoggins
enabled auto-merge (squash)
September 30, 2026 00:00
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add macOS Arm64 CoreCLR build artifacts for performance runs on
osx.26.arm64.m4.perf.osx_arm64platform to the existing CoreCLR performance build template.Companion PR: dotnet/performance#5323 adds the M4 microbenchmark job. This runtime change must land and be available to the internal performance pipeline before that job is enabled.
Validation
Six local YAML/structural checks passed across both repositories, covering duplicate keys, platform and queue selection, release guards, cross-build forwarding, artifact naming, and preservation of existing jobs.
git diff --checkpassed.No macOS build, Azure Pipelines template expansion, or end-to-end Helix run was performed locally; those still require pipeline validation.
Note
This PR was prepared with GitHub Copilot; this description is AI-generated.