Skip to content

Fix RISC-V JIT stack store and cast check bugs - #134584

Open
am11 wants to merge 1 commit into
dotnet:mainfrom
am11:feature/small-int-cast/riscv64-checks
Open

am11 wants to merge 1 commit into
dotnet:mainfrom
am11:feature/small-int-cast/riscv64-checks

Conversation

@am11

@am11 am11 commented Sep 24, 2026

Copy link
Copy Markdown
Member

Storing a contained constant to a stack local built it in the reserved
register, which the emitter reused to form large frame offsets, so the
stored value was clobbered. Small-int overflow checks on int sources
compared all 64 bits, although the upper half of an int register is
not guaranteed to be sign-extended. Complex Tan/Tanh tests now honor
the NaN payload policy for zero signs derived from NaN inputs.

Fixes #130562

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Sep 24, 2026
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 24, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@am11 am11 added the arch-riscv Related to the RISC-V architecture label Sep 24, 2026
@am11
am11 requested review from a team, jakobbotsch, tannergooding and tomeksowi September 24, 2026 11:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.Runtime.Numerics.Tests failing on linux-riscv64

1 participant