Remove unused short-summary support from superpmi.py - #134509
Open
jakobbotsch with Copilot wants to merge 1 commit into
Open
jakobbotsch with Copilot wants to merge 1 commit into
jakobbotsch with Copilot wants to merge 1 commit into
Conversation
Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jakobbotsch
September 23, 2026 11:35
View session
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
|
PTAL @dotnet/jit-contrib |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Removes unused short-summary generation from SuperPMI while preserving full summaries, JSON output, and CLI behavior.
Changes:
- Removes short-summary file creation.
- Removes
include_detailsparameters and branches. - Updates summary-generation callers.
| File | Description |
|---|---|
src/coreclr/scripts/superpmi.py |
Removes short-summary support and simplifies summary generation. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove SuperPMI’s short summaries, which were never used.
asmdiffs,tpdiff,metricdiff, andsummarize.include_detailsparameters and conditional branches, preserving full-summary content, JSON output, and existing CLI options.Note
This description was generated by GitHub Copilot.