Inline GetEnumerator under NativeAOT - #134427
Merged
Merged
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is narrowly scoped; the requested measurements are a non-blocking nit.
Review effort: Lite
Findings: None
What changed in this PR
Adds aggressive inlining to NativeAOT’s generic array GetEnumerator, enabling optimized interface-based foreach loops.
Changes:
- Applies
AggressiveInliningtoArray<T>.GetEnumerator().
| File | Summary |
|---|---|
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Array.NativeAot.cs |
Enables inlining for NativeAOT array enumeration. |
Member
|
Matches equivalent method in CoreCLR w/ JIT: LGTM |
jkotas
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while working on #131265.
We were not inlining
GetEnumeratorhere under NativeAOT, leading to foreach over array interfaces not able to be inlined even after devirtualization.