[release/11.0] Expose Composite ML-DSA CNG identifiers - #134162
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
It adds new experimental public API surface on a release branch and should receive maintainer validation (including final build/test results and platform support considerations).
Pull request overview
This PR backports the addition of experimental Composite ML-DSA CNG identifiers to the release/11.0 branch by exposing new CompositeMLDsa properties on CngAlgorithm and CngAlgorithmGroup, and updating tests to use the product API instead of a test-only shim.
Changes:
- Expose
CngAlgorithm.CompositeMLDsaandCngAlgorithmGroup.CompositeMLDsaas experimental public API. - Update
System.Security.Cryptographyref assembly to include the new public properties withExperimental("SYSLIB5006"). - Remove the test-only
CngAlgorithm.CompositeMLDsashim from the Composite ML-DSA CNG test helpers.
File summaries
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithmGroup.cs | Makes CompositeMLDsa a public experimental CngAlgorithmGroup identifier. |
| src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithm.cs | Makes CompositeMLDsa a public experimental CngAlgorithm identifier. |
| src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs | Adds the new public API members to the ref contract with Experimental("SYSLIB5006"). |
| src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaTestHelpers.Cng.cs | Removes the test-only identifier shim now that the product API exists. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
Member
|
Hii, |
bartonjs
approved these changes
Sep 18, 2026
PranavSenthilnathan
added
the
Servicing-consider
Member
Author
|
/ba-g #133311 |
artl93
added
Servicing-approved
artl93
pushed a commit
that referenced
this pull request
Sep 19, 2026
main PR: #132440 # Description Add the experimental Composite ML-KEM base APIs, algorithm identifiers, and key import/export support. Straight backport; no additional code changes. Stack layer 2/4, based on #134162, targeting RC2. # Customer Impact Provides the new hybrid PQC API surface. Requires the implementation layers #134164 and #134165. # Regression No. New APIs. # Testing Includes the original contract and import/export tests. Cherry-pick equivalence verified; no local builds or tests run for this layer. # Risk Low. Adds new experimental APIs without changing existing API behavior. Ships together with the implementation layers. > [!NOTE] > This PR description was generated with GitHub Copilot. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5676db47-d54b-4946-97ec-7fc0a7392c30 Copilot-Session: 17bb5da2-badb-480f-a196-71dc1e23dc7b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main PR: #132353
Description
Expose the experimental Composite ML-DSA CNG identifiers in .NET 11 RC2.
Straight backport; no additional code changes. Stack layer 1/4, targeting
release/11.0.Customer Impact
Completes the new PQC API surface so callers can use named CNG identifiers
instead of provider-specific strings.
Regression
No. New APIs.
Testing
Windows Release build passed. Full crypto suite: 17,454 total, 1 failed,
407 skipped. The X509 key-file cleanup test failed; its targeted rerun
passed all 6 cases. The initial failure's cause is undetermined.
Cherry-pick equivalence verified.
Risk
Low. Exposes existing identifiers as new experimental APIs without
changing the cryptographic implementation.
Note
This PR description was generated with GitHub Copilot.