[release/11.0] Honor JsonNumberHandlingAttribute declarations on C# unions - #133951
Merged
Merged
Conversation
Co-authored-by: eiriktsarpalis <2813363+eiriktsarpalis@users.noreply.github.com>
Co-authored-by: eiriktsarpalis <2813363+eiriktsarpalis@users.noreply.github.com>
Co-authored-by: eiriktsarpalis <2813363+eiriktsarpalis@users.noreply.github.com>
Co-authored-by: eiriktsarpalis <2813363+eiriktsarpalis@users.noreply.github.com>
Co-authored-by: eiriktsarpalis <2813363+eiriktsarpalis@users.noreply.github.com>
Co-authored-by: eiriktsarpalis <2813363+eiriktsarpalis@users.noreply.github.com>
Co-authored-by: eiriktsarpalis <2813363+eiriktsarpalis@users.noreply.github.com>
This reverts commit 368c090. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Apply union number handling to structural classification, source-generator ambiguity diagnostics, and schema export. Cover Web defaults, metadata precedence, nullable cases, and context isolation in the corresponding test suites. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Set the read/write frame handling from the union override or the selected case metadata. Cover numeric and nullable cases, collection continuations, precedence, and POCO member independence. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Carry the originating JsonTypeInfo in an internal context property so structural classification honors directly supplied contract overrides without resolving another contract through options. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json |
eiriktsarpalis
added
the
Servicing-consider
tannergooding
approved these changes
Sep 15, 2026
Member
|
/ba-g test failures are unrelated |
This was referenced Sep 15, 2026
artl93
approved these changes
Sep 15, 2026
artl93
left a comment
artl93
left a comment
Member
There was a problem hiding this comment.
New for .NET 11, customer reported. Approved.
artl93
added
Servicing-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #133673 to release/11.0
/cc @eiriktsarpalis @copilot
Customer Impact
Fixes a customer reported functionality gap between two newly introduced features in .NET 11: union support and
JsonNumberHandlingAttribute.Regression
Testing
Added tests covering the impacted scenaria.
Risk
Low. Makes straightforward additions to product code addressing the missing functionality.