Use private PKI for untrusted TLS session certificate test - #133875
Merged
Merged
Conversation
Generate a fresh certificate chain instead of relying on the shared test CA being untrusted. Send the generated chain and assert RemoteCertificateChainErrors explicitly. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is focused, deterministic, and has no unresolved review issues.
Pull request overview
Updates the TLS session test to use a freshly generated private PKI chain, making untrusted-certificate validation deterministic.
Changes:
- Generates a fresh localhost certificate chain.
- Supplies the full chain to the server.
- Verifies the expected chain validation error.
File summaries
| File | Description |
|---|---|
src/libraries/System.Net.Security/tests/FunctionalTests/TlsSessionTests.cs |
Makes the untrusted-certificate test independent of machine trust-store state. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
This was referenced Sep 14, 2026
ManickaP
approved these changes
Sep 15, 2026
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 18, 2026
…3875) System.Net.Security.Tests.TlsSessionTests.ClientSession_ExternalCertificateValidation_AcceptWithDefaultValidation_FailsOnUntrustedCert used to fail on my machine because the issuer cert was installed on my trust root. Change the test to generate a fresh certificate chain instead of relying on the shared test CA being untrusted. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.Net.Security.Tests.TlsSessionTests.ClientSession_ExternalCertificateValidation_AcceptWithDefaultValidation_FailsOnUntrustedCert used to fail on my machine because the issuer cert was installed on my trust root. Change the test to generate a fresh certificate chain instead of relying on the shared test CA being untrusted.