JIT: Fix block-store address containment boundary - #133803
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: dc2793e8-3f85-4610-9afb-2b990ed92316
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Fixes a JIT block-store containment boundary mismatch that could trigger checked-build assertions.
Changes:
- Tightens xarch and ARM64 containment bounds.
- Adds regression coverage for initialization, copy, and load paths.
File summaries
| File | Description |
|---|---|
src/tests/JIT/Regression_ro_2/Runtime_133785.cs |
Adds boundary block-store regression tests. |
src/coreclr/jit/lowerxarch.cpp |
Rejects the unsupported boundary displacement. |
src/coreclr/jit/lowerarmarch.cpp |
Applies equivalent ARM64 boundary handling. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
This was referenced Sep 13, 2026
Member
Author
|
PTAL @dhartglassMSFT |
| public class Runtime_133785 | ||
| { | ||
| // On x64, the element offset is 16 + Index * 3 == int.MaxValue - 3. | ||
| private const int Index = 715827876; |
Contributor
There was a problem hiding this comment.
Setting this to 715827875 instead still hits an assert in codegenarmarch due to some overflowing signed int math in UnrollInitBlock. Bug existed before your change though so up to you if its easy enough to fix while youre in here.
Member
Author
There was a problem hiding this comment.
ah, interesting, I'll check
dhartglassMSFT
approved these changes
Sep 15, 2026
Member
Author
|
/ba-g unstable mono |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133785
Align block-store containment bounds with codegen assertions on xarch and ARM64; add regression coverage.