Classify Wasm P/Invokes before R2R codegen

[lewing]

Summary

Preserve .NET P/Invoke call-site semantics for CoreCLR WebAssembly ReadyToRun images without relying on runtime fallback to stripped IL.

Crossgen2 now distinguishes P/Invokes that can be emitted directly from those that require runtime resolution:

• modules supplied through --directpinvoke, QCalls, and * static imports remain direct R2R P/Invokes;
• WasmImportLinkageAttribute remains direct and resolves through the WebAssembly import table rather than the static native-module list;
• ordinary imports not proven statically available are treated as requiring marshalling, so callers remain valid R2R methods and resolution occurs only when the P/Invoke is reached.

Browser and WASI app builds pass their supported module lists to Crossgen2. CoreLib and prebuilt browser framework R2R generation use the same canonical framework list as the portable call-helper generator. The canonical build configuration lives under eng/wasm and is packaged beside the browser runtime SDK target for out-of-tree builds. A shared WASM build task computes the effective module set for browser and WASI, including platform applicability, invariant globalization, supported native inputs, canonical module names, and deduplication.

The module list is written to an incremental-build manifest so adding or removing a native module invalidates the corresponding R2R images.

The earlier VM-level method-rejection implementation has been removed. This avoids a new R2R-to-IL fallback path and remains compatible with --strip-il-bodies.

Addresses the Runtime_58874 failure tracked by #133259 and the broader guarded-platform-probe behavior reported in #133614.

Validation

• Crossgen2/CoreCLR build: passed.
• NativeAOT compiler build: passed.
• Browser-wasm CoreCLR runtime, CoreLib, framework R2R, and runtime pack build: passed.
• WASI CoreCLR runtime and runtime pack build: passed.
• Browser-wasm R2R Interop/PInvoke/Unresolved/UnresolvedPInvokeTests passed with --strip-il-bodies and --directpinvoke:libSystem.Native.
• WASI R2R Interop/PInvoke/Unresolved/UnresolvedPInvokeTests passed with the same stripped-IL configuration.
• Packaged workload WBT for CoreCLR R2R + NativeFileReference passed, including native relinking, native-lib module classification, and the P/Invoke result.
• The preserved pre-policy browser runtime fails the call-site timing assertion under --strip-il-bodies; the new policy passes it.
• R2RDump confirms the image has READYTORUN_FLAG_StrippedILBodies, configured libSystem.Native calls retain PINVOKE_TARGET fixups, and unresolved callers do not embed those fixups.
• CoreCLR browser sample publish with R2R and native relinking: passed; its generated P/Invoke manifest matches the call-helper module list.
• Native test execution: passed.

No benchmark is applicable to permanently unavailable imports. Configured direct P/Invokes retain the existing direct PINVOKE_TARGET codegen and add no runtime branch.

Note

This pull request description and changes were prepared with GitHub Copilot assistance.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[dotnet-policy-service]

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Copilot review overview

🟡 Changes recommended

Critical deferred-resolution and test-project configuration issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review tier: Lite
Findings: 3

Open findings (3)

• Interpreter fallback still resolves missing imports eagerly · New
• Interpreter fallback still resolves P/Invokes eagerly · New
• Add the required TestLibrary project reference · New

What changed in this PR

This PR updates WASM ReadyToRun P/Invoke resolution to defer unresolved imports and adds regression coverage for call-site failure timing.

Changes:

• Adds WASM-specific P/Invoke fallback resolution.
• Removes the Runtime_58874 quarantine.
• Adds unresolved P/Invoke timing tests and isolated test configuration.

File	Summary
src/​tests/​JIT/​Regression_o_2/​Runtime_58874.cs	Removes the WASM/R2R quarantine.
src/​tests/​Interop/​PInvoke/​Unresolved/​UnresolvedPInvokeTests.csproj	Adds the isolated test project; critical: missing TestLibraryProjectPath reference may prevent the generated runner from compiling or running.
src/​tests/​Interop/​PInvoke/​Unresolved/​UnresolvedPInvokeTests.cs	Adds call-site failure timing coverage.
src/​coreclr/​vm/​jitinterface.cpp	Adds unresolved WASM R2R fallback; critical: interpreter compilation can still eagerly resolve imports or hit a portability assertion.
src/​coreclr/​vm/​dllimport.h	Declares the WASM resolution helper.
src/​coreclr/​vm/​dllimport.cpp	Implements override-based resolution; critical: fallback may still resolve before managed entry instead of deferring failure to the call site.

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved WebAssembly P/Invokes still fail during interpreter compilation instead of at the call site.

Review tier: Lite
Findings: 3

Open findings (3)

• Add the required TestLibrary project reference
• Interpreter fallback still resolves P/Invokes eagerly
• Interpreter fallback still resolves missing imports eagerly

[Copilot]

Copilot review overview

🔵 Needs a closer look

Resolve the module-list/archive synchronization issue and update regression coverage for the canonical System.Native spelling.

Review effort: Lite
Findings: None

[Copilot]

Copilot review overview

🔵 Needs a closer look

The broad runtime/build changes include a moderate gap in proving direct R2R emission and warrant human review.

Review effort: Lite
Findings: None

[pavelsavara]

Does this need to regenerate src\coreclr\vm\wasm\browser\callhelpers-pinvoke.cpp and src\coreclr\vm\wasm\wasi\callhelpers-pinvoke.cpp ?

[Copilot]

Copilot review overview

🔵 Needs a closer look

Targeted R2R coverage is still missing for NativeLibrary inputs, invariant globalization, and Browser/WASI module filtering.

Review effort: Lite
Findings: None

Previously missed (1)

In code that hasn't changed since last review

Add R2R coverage for module policy branches

src/​tasks/​WasmAppBuilder/​ComputeWasmPInvokeModules.cs:65

These branches now determine which modules receive --directpinvoke for CoreCLR ReadyToRun, but the new ReadyToRun workload test covers only a custom NativeFileReference. The NativeLibrary path, invariant-globalization filtering, and Browser/WASI applicability are not exercised by an R2R test; the existing invariant test only validates the non-R2R native relink. Add focused R2R coverage for these cases so a regression cannot classify an unavailable module as direct.

[!NOTE] This review comment was generated with GitHub Copilot assistance.

[lewing]

Does this need to regenerate src\coreclr\vm\wasm\browser\callhelpers-pinvoke.cpp and src\coreclr\vm\wasm\wasi\callhelpers-pinvoke.cpp ?

Browser had become slightly stale again. Fixed.

I'm going to open a separate pr that adds a CI check to regenerate the baseline and compare to the checked in version to avoid drift.