Skip to content

Re-enable ContextualReflection test for CoreCLR browser WASM - #133262

Open
davidwrighton with Copilot wants to merge 4 commits into
mainfrom
copilot/re-enable-contextual-reflection-test
Open

davidwrighton with Copilot wants to merge 4 commits into
mainfrom
copilot/re-enable-contextual-reflection-test

Conversation

Copilot AI commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Loader/ContextualReflection was disabled on CoreCLR browser WASM by #132491 due to #131925 (OBJECTREF being accessed while thread is in preemptive GC mode assert). That failure is believed fixed, so the exclusion is removed.

Changes

  • ContextualReflection.csproj — removed the CLRTestTargetUnsupported condition for RuntimeFlavor=coreclr + TargetOS=browser added in Disable ContextualReflection test on browser wasm #132491.

  • ContextualReflection.cs — removed the [ActiveIssue] skip on TestEntryPoint for the same issue, added earlier in [browser][CoreCLR] Gate remaining priority-1 outerloop failures #131957:

    [ActiveIssue("https://github.com/dotnet/runtime/issues/131925", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]

    The issue was gated twice. Dropping only the csproj property would leave the test skipped at runtime on browser WASM, making the change a no-op. No other platform or runtime flavor is affected — the remaining NativeAOT and Mono ActiveIssue attributes are untouched.

Notes for reviewers

  • Issue Assert failure: !"OBJECTREF being accessed while thread is in preemptive GC mode." #131925 is still open upstream; worth confirming the fix landed (and closing it) before merging.
  • Validation here was MSBuild property evaluation only — -p:TargetOS=browser -p:TargetArchitecture=wasm -p:RuntimeFlavor=coreclr -getProperty:CLRTestTargetUnsupported now returns empty for this project, while a control project that retains its exclusion still returns true. The real signal is the browser WASM CI leg on this PR.

Note

This PR description was generated by GitHub Copilot.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
16 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI and others added 2 commits September 4, 2026 21:03
Co-authored-by: davidwrighton <10779849+davidwrighton@users.noreply.github.com>
Co-authored-by: davidwrighton <10779849+davidwrighton@users.noreply.github.com>
Copilot AI changed the title [WIP] Re-enable ContextualReflection test for browser WASM target Re-enable ContextualReflection test for CoreCLR browser WASM Sep 4, 2026
Copilot AI requested a review from davidwrighton September 4, 2026 21:12
@davidwrighton
davidwrighton marked this pull request as ready for review September 4, 2026 21:17
Copilot AI lite review requested due to automatic review settings September 4, 2026 21:17
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change only removes redundant gating to re-enable an existing test, without altering test logic or product code paths.

Pull request overview

This PR re-enables the Loader/ContextualReflection test on CoreCLR browser WASM by removing the build-time exclusion and the runtime [ActiveIssue] skip that previously prevented the test from running in that configuration.

Changes:

  • Removes the CLRTestTargetUnsupported gate for RuntimeFlavor=coreclr + TargetOS=browser so the project is included again for CoreCLR browser runs.
  • Removes the browser+CoreCLR-specific [ActiveIssue] on TestEntryPoint, ensuring the test actually executes when the project is re-enabled.
File summaries
File Description
src/tests/Loader/ContextualReflection/ContextualReflection.csproj Removes the CoreCLR+browser MSBuild property that marked the test as unsupported.
src/tests/Loader/ContextualReflection/ContextualReflection.cs Removes the browser+CoreCLR ActiveIssue skip so the test runs at runtime again.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

Copilot AI review requested due to automatic review settings September 17, 2026 12:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Targeted CoreCLR browser-WASM validation or evidence of the underlying fix is still required.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

@@ -34,7 +34,6 @@ public class Program : IProgram

[ActiveIssue("https://github.com/dotnet/runtimelab/issues/165", typeof(Utilities), nameof(Utilities.IsNativeAot))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34072", TestRuntimes.Mono)]
@@ -1,7 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasm WebAssembly architecture area-System.Reflection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants