[release/11.0] Restore current task tracking for runtime async dispatch - #133015
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
steveisok
self-requested a review
September 1, 2026 13:39
steveisok
approved these changes
Sep 1, 2026
Contributor
|
Tagging subscribers to this area: @agocke |
Member
|
@steveisok @max-charlamb can you please fill out the servicing template? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #132969 to release/11.0
/cc @max-charlamb
Customer Impact
On the standard, non-instrumented runtime-async dispatch path,
AsyncDispatcherInfo.CurrentTaskis not populated. As a result, diagnostics tools analyzing a live process or crash dump cannot deterministically associate a runtime-async continuation chain with its parentTask, which can produce incomplete or incorrect async task relationships. The issue affects .NET 11 runtime-async diagnostics when instrumentation is not enabled.Regression
This regression was introduced by #126091, when the instrumented and non-instrumented continuation-dispatch paths were separated. Before that change, the shared dispatch path populated
CurrentTask. The instrumented path still sets it throughRuntimeAsyncInstrumentationHelpers.ResumeRuntimeAsyncContext, but the standard path lost the assignment.Testing
The corresponding fix on
mainbuilt Release CoreCLR and libraries successfully and ranSystem.Runtime.Testswith 77,810 tests passing and 88 skipped. BenchmarkDotNet testing covered 10 million runtime-async suspension/resumption operations per invocation and found no performance regression across 10 paired runs.No new test was added because this change restores diagnostic metadata held in stack-local dispatcher state rather than changing observable task execution behavior. The issue was missed when #126091 split the dispatch paths because existing tests validate runtime-async behavior and instrumentation, but do not inspect the non-instrumented stack state consumed by live-process and crash-dump diagnostics.
Risk
Low. The change adds one pointer assignment to a stack-local
AsyncDispatcherInfoimmediately before continuation dispatch. It restores the behavior that existed before #126091 and matches the current-task tracking already performed by the instrumented path. It does not change control flow, public APIs, task completion semantics, or persisted data. Performance measurements detected no regression; ReadyToRun code size forRuntimeAsyncTask<int>.DispatchContinuationsincreased by 7 bytes, from 1,488 to 1,495 bytes.IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.